Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1257793005:
Devtools UI: Enable tooltips by default (Closed)
|
Created:
5 years, 5 months ago by samli Modified:
5 years, 4 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionDevtools UI: Enable tooltips by default
BUG=513066
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200712
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 23 (9 generated)
samli@chromium.org changed reviewers: + dgozman@chromium.org
With the shortcuts in, it seems everyone is pretty happy with it.
I think tooltips are not ready yet. We have a bunch of old-style titles, which should be converted. To name a few: - breadcrumbs; - errors/warnings; - everything in device mode; - "Insert Style Rule"; - all checkboxes.
On 2015/07/27 at 09:54:04, dgozman wrote: > I think tooltips are not ready yet. We have a bunch of old-style titles, which should be converted. To name a few: > - breadcrumbs; I don't think should be using any tooltip/title at all. > - errors/warnings; > - everything in device mode; > - "Insert Style Rule"; > - all checkboxes. Ok, sorry I didn't realise these were all in scope. Spoke to paulirish@ and he thinks we should change as many as possible. Should we be changing them all or just the most visible ones?
On 2015/07/28 08:13:40, samli wrote: > On 2015/07/27 at 09:54:04, dgozman wrote: > > I think tooltips are not ready yet. We have a bunch of old-style titles, which > should be converted. To name a few: > > - breadcrumbs; > I don't think should be using any tooltip/title at all. But they have now, and we either remove them or use the new tooltip. > > - errors/warnings; > > - everything in device mode; > > - "Insert Style Rule"; > > - all checkboxes. > > Ok, sorry I didn't realise these were all in scope. Spoke to paulirish@ and he > thinks we should change as many as possible. > Should we be changing them all or just the most visible ones? I think it's strange to have two types of tooltips across the UI. Better converge all of them.
On 2015/07/28 at 08:29:11, dgozman wrote: > On 2015/07/28 08:13:40, samli wrote: > > On 2015/07/27 at 09:54:04, dgozman wrote: > > > I think tooltips are not ready yet. We have a bunch of old-style titles, which > > should be converted. To name a few: > > > - breadcrumbs; > > I don't think should be using any tooltip/title at all. > But they have now, and we either remove them or use the new tooltip. > > > > - errors/warnings; > > > - everything in device mode; > > > - "Insert Style Rule"; > > > - all checkboxes. > > > > Ok, sorry I didn't realise these were all in scope. Spoke to paulirish@ and he > > thinks we should change as many as possible. > > Should we be changing them all or just the most visible ones? > > I think it's strange to have two types of tooltips across the UI. Better converge all of them. FWIW: I don't think it should be a blocker to change every instance of native tooltips before we enable this.
ping dgozman after https://codereview.chromium.org/1271193002 lands
ping
The CQ bit was checked by pfeldman@chromium.org
lgtm
The CQ bit was unchecked by pfeldman@chromium.org
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257793005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by samli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257793005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257793005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by samli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1257793005/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257793005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257793005/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200712 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
