Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Issue 1257733003: Change _internal from private so we work across library boundaries (Closed)

Created:
5 years, 5 months ago by terry
Modified:
5 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/integration
Visibility:
Public.

Description

Change _internal from private so we work across library boundaries TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/f570cedb42cc6ac01d34bb676e8d4f9083269c5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1246 lines, -1246 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 401 chunks +802 lines, -802 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 11 chunks +22 lines, -22 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 142 chunks +284 lines, -284 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 27 chunks +54 lines, -54 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 35 chunks +70 lines, -70 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
terry
Committed patchset #1 (id:1) manually as f570cedb42cc6ac01d34bb676e8d4f9083269c5b (presubmit successful).
5 years, 5 months ago (2015-07-24 20:14:43 UTC) #1
Alan Knight
5 years, 5 months ago (2015-07-24 20:16:24 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698