Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 125773002: Mojo: Remove unused hello_world_service code (Closed)

Created:
6 years, 11 months ago by darin (slow to review)
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Remove unused hello_world_service code Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243364

Patch Set 1 #

Patch Set 2 : Include GYP changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -99 lines) Patch
D mojo/examples/hello_world_service/hello_world_service.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/examples/hello_world_service/hello_world_service_impl.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/examples/hello_world_service/hello_world_service_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M mojo/mojo.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo_examples.gypi View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
6 years, 11 months ago (2014-01-07 07:45:13 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-07 16:03:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/125773002/30001
6 years, 11 months ago (2014-01-07 16:59:34 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:39:57 UTC) #4
Message was sent while issue was closed.
Change committed as 243364

Powered by Google App Engine
This is Rietveld 408576698