Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1257723002: Simplify ownership of a ThreadState's interruptors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Switch addInterruptor() to take a PassOwnPtr<> Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/ThreadState.h ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.cpp
diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp
index 2fabba119a8053e5e04360f5b13ad5a458f82a1a..079ac1912d0ce202fbbc8a761bbc15343b422211 100644
--- a/Source/platform/heap/ThreadState.cpp
+++ b/Source/platform/heap/ThreadState.cpp
@@ -139,9 +139,6 @@ ThreadState::~ThreadState()
for (int i = 0; i < NumberOfHeaps; ++i)
delete m_heaps[i];
- for (Interruptor* interruptor : m_interruptors)
- delete interruptor;
-
**s_threadSpecific = nullptr;
if (isMainThread()) {
s_mainThreadStackStart = 0;
@@ -1283,7 +1280,7 @@ void ThreadState::copyStackUntilSafePointScope()
}
}
-void ThreadState::addInterruptor(Interruptor* interruptor)
+void ThreadState::addInterruptor(PassOwnPtr<Interruptor> interruptor)
{
ASSERT(checkThread());
SafePointScope scope(HeapPointersOnStack);
« no previous file with comments | « Source/platform/heap/ThreadState.h ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698