Issue 1257683004: Steal refs from other TextBatch in onCombineIfPossible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257683004: Steal refs from other TextBatch in onCombineIfPossible (Closed)

Created:
5 years, 5 months ago by bsalomon

Modified:
5 years, 4 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@implicitsize

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Steal refs from other TextBatch in onCombineIfPossible Committed: https://skia.googlesource.com/skia/+/1c63436f39796d3ed5f27f54d07f6cc120006b94

Patch Set 1 #

Patch Set 2 : rebase #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	src/gpu/GrAtlasTextContext.cpp	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257683004/20001

5 years, 4 months ago (2015-07-27 13:52:06 UTC) #6

commit-bot: I haz the power

5 years, 4 months ago (2015-07-27 14:00:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1c63436f39796d3ed5f27f54d07f6cc120006b94

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages