iOS factories for SigninManager and GaiaCookieManagerService

ios/chrome/browser/signin/signin_manager_factory.h

Index: ios/chrome/browser/signin/signin_manager_factory.h
diff --git a/ios/chrome/browser/signin/signin_manager_factory.h b/ios/chrome/browser/signin/signin_manager_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..15bf5f8c681786115c36a46c4bb8f052d0393a55
--- /dev/null
+++ b/ios/chrome/browser/signin/signin_manager_factory.h
@@ -0,0 +1,85 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_SIGNIN_SIGNIN_MANAGER_FACTORY_H_
+#define IOS_CHROME_BROWSER_SIGNIN_SIGNIN_MANAGER_FACTORY_H_
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/observer_list.h"
+#include "components/keyed_service/ios/browser_state_keyed_service_factory.h"
+
+template <typename T>
+struct DefaultSingletonTraits;
+
+class SigninManager;
+class SigninManagerBase;
+class PrefRegistrySimple;
+
+namespace ios {
+
+class ChromeBrowserState;
+
+// Singleton that owns all SigninManagers and associates them with browser
+// states.
+class SigninManagerFactory : public BrowserStateKeyedServiceFactory {
+ public:
+  class Observer {

[sdefresne, 2015/07/24 12:38:46]

Can you move out of the factory so that it can be forward-declared. Maybe rename
SigninManagerFactoryObserver.

+   public:
+    // Called when a SigninManager(Base) instance is created.

[sdefresne, 2015/07/24 12:38:46]

Since you are writing this interface, why not directly pass the managed as the
correct type:

virtual void SigninManagerCreated(SigninManager* manager) {}
virtual void SigninManagerShutdown(SigninManager* manager) {}

+    virtual void SigninManagerCreated(SigninManagerBase* manager) {}
+
+    // Called when a SigninManager(Base) instance is being shut down. Observers
+    // of |manager| should remove themselves at this point.
+    virtual void SigninManagerShutdown(SigninManagerBase* manager) {}
+
+   protected:
+    virtual ~Observer() {}

[sdefresne, 2015/07/24 12:38:46]

I prefer to have public destructors on Observers so that code can have
scoped_ptr<> to the base class in their public interface, and restrict the
visibility of the derived class name to the implementation file.

You also need to provide a constructor (will be required once you add the
DISALLOW_COPY_AND_ASSIGN). If you want to avoid creation of base Observers, mark
it as protected.

+  };

[sdefresne, 2015/07/24 12:38:47]

DISALLOW_COPY_AND_ASSIGN()

+
+  static SigninManager* GetForBrowserState(
+      ios::ChromeBrowserState* browser_state);
+  static SigninManager* GetForBrowserStateIfExists(
+      ios::ChromeBrowserState* browser_state);
+  //  static const SigninManager* GetForBrowserStateIfExists(const

[sdefresne, 2015/07/24 12:38:46]

Please remove.

+  //  ios::ChromeBrowserState* browser_state);
+
+  // Returns an instance of the SigninManagerFactory singleton.
+  static SigninManagerFactory* GetInstance();
+
+  // Implementation of BrowserStateKeyedServiceFactory (public so tests
+  // can call it).
+  void RegisterBrowserStatePrefs(
+      user_prefs::PrefRegistrySyncable* registry) override;
+
+  // Registers the browser-global prefs used by SigninManager.
+  static void RegisterPrefs(PrefRegistrySimple* registry);
+
+  // Methods to register or remove observers of SigninManager creation/shutdown.
+  void AddObserver(Observer* observer);
+  void RemoveObserver(Observer* observer);
+
+  // Notifies observers of |manager|'s creation. Should be called only by test
+  // SigninManager subclasses whose construction does not occur in
+  // |BuildServiceInstanceFor()|.
+  void NotifyObserversOfSigninManagerCreationForTesting(
+      SigninManagerBase* manager);
+
+ private:
+  friend struct DefaultSingletonTraits<SigninManagerFactory>;
+
+  SigninManagerFactory();
+  ~SigninManagerFactory() override;
+
+  // List of observers. Checks that list is empty on destruction.
+  mutable base::ObserverList<Observer, true> observer_list_;
+
+  // BrowserStateKeyedServiceFactory:
+  scoped_ptr<KeyedService> BuildServiceInstanceFor(
+      web::BrowserState* context) const override;
+  void BrowserStateShutdown(web::BrowserState* context) override;
+};
+}
+
+#endif  // IOS_CHROME_BROWSER_SIGNIN_SIGNIN_MANAGER_FACTORY_H_