Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1257653011: Filter out recorded slots of deoptimized code objects directly after deoptimization. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Filter out recorded slots of deoptimized code objects directly after deoptimization. BUG=chromium:507211 LOG=n Committed: https://crrev.com/be5c115952cfd53072bbac3c4f2b6dd068dfde53 Cr-Commit-Position: refs/heads/master@{#30089}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -50 lines) Patch
M src/heap/mark-compact.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 6 chunks +5 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-04 07:35:27 UTC) #2
Michael Starzinger
LGTM if one comment is addressed. https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc#newcode3615 src/heap/mark-compact.cc:3615: if (!p->IsEvacuationCandidate() && ...
5 years, 4 months ago (2015-08-04 07:45:58 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/1257653011/diff/20001/src/heap/mark-compact.cc#newcode3615 src/heap/mark-compact.cc:3615: if (!p->IsEvacuationCandidate() && On 2015/08/04 07:45:57, Michael Starzinger wrote: ...
5 years, 4 months ago (2015-08-10 12:04:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257653011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257653011/40001
5 years, 4 months ago (2015-08-10 12:05:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-10 12:31:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 12:31:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be5c115952cfd53072bbac3c4f2b6dd068dfde53
Cr-Commit-Position: refs/heads/master@{#30089}

Powered by Google App Engine
This is Rietveld 408576698