Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1257643005: Reland #1: Switch the default build configuration to use the 10.10 SDK. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
Nico, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #1: Switch the default build configuration to use the 10.10 SDK. All known problems have been fixed since the first attempt to land this CL. Original issue's description: > mac: Switch the default build configuration to use the 10.10 SDK. > > This change is intended to be temporary. The goal is to release a Canary > compiled against the 10.10 SDK, and then to revert this CL. > > BUG=463170 > > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451 > Cr-Commit-Position: refs/heads/master@{#340992} TBR=thakis@chromium.org,amineer@chromium.org BUG=463170 Committed: https://crrev.com/345c0cf47947f209e628941b38d76dca90aee49d Cr-Commit-Position: refs/heads/master@{#341261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/mac/mac_sdk.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257643005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257643005/1
5 years, 4 months ago (2015-07-31 00:23:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 01:31:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/345c0cf47947f209e628941b38d76dca90aee49d Cr-Commit-Position: refs/heads/master@{#341261}
5 years, 4 months ago (2015-07-31 01:32:27 UTC) #4
dmurph
5 years, 4 months ago (2015-07-31 10:06:57 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1266603007/ by dmurph@chromium.org.

The reason for reverting is: I believe this is causing a lot of issues with
layout, no idea why though.
https://code.google.com/p/chromium/issues/detail?id=515836.

Powered by Google App Engine
This is Rietveld 408576698