Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/IceTargetLoweringX8632.h

Issue 1257643004: Subzero. Buildable, non-functional TargetLoweringX8664. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: git pull Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX86Base.h ('k') | src/IceTargetLoweringX8664.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX8632.h
diff --git a/src/IceTargetLoweringX8632.h b/src/IceTargetLoweringX8632.h
index 598e6a122b2224af5f01a12d0454901ad9afe25f..f49e6737a95a2cb19667a2ee931da819167da5f4 100644
--- a/src/IceTargetLoweringX8632.h
+++ b/src/IceTargetLoweringX8632.h
@@ -41,7 +41,9 @@ public:
static TargetX8632 *create(Cfg *Func) { return new TargetX8632(Func); }
-protected:
+private:
+ friend class ::Ice::X86Internal::TargetX86Base<TargetX8632>;
+
Operand *createNaClReadTPSrcOperand() {
Constant *Zero = Ctx->getConstantZero(IceType_i32);
return Traits::X86OperandMem::create(Func, IceType_i32, nullptr, Zero,
@@ -49,9 +51,6 @@ protected:
Traits::X86OperandMem::SegReg_GS);
}
-private:
- friend class ::Ice::X86Internal::TargetX86Base<TargetX8632>;
-
explicit TargetX8632(Cfg *Func) : TargetX86Base(Func) {}
};
@@ -61,8 +60,10 @@ class TargetDataX8632 final : public TargetDataLowering {
TargetDataX8632 &operator=(const TargetDataX8632 &) = delete;
public:
+ ~TargetDataX8632() override = default;
+
static std::unique_ptr<TargetDataLowering> create(GlobalContext *Ctx) {
- return std::unique_ptr<TargetDataLowering>(new TargetDataX8632(Ctx));
+ return makeUnique<TargetDataX8632>(Ctx);
}
void lowerGlobals(const VariableDeclarationList &Vars,
@@ -70,11 +71,10 @@ public:
void lowerConstants() override;
void lowerJumpTables() override;
-protected:
- explicit TargetDataX8632(GlobalContext *Ctx);
-
private:
- ~TargetDataX8632() override = default;
+ ENABLE_MAKE_UNIQUE;
+
+ explicit TargetDataX8632(GlobalContext *Ctx);
template <typename T> static void emitConstantPool(GlobalContext *Ctx);
};
« no previous file with comments | « src/IceInstX86Base.h ('k') | src/IceTargetLoweringX8664.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698