src/IceAssemblerX86BaseImpl.h - Issue 1257643004: Subzero. Buildable, non-functional TargetLoweringX8664.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX86BaseImpl.h

Issue 1257643004: Subzero. Buildable, non-functional TargetLoweringX8664. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: git pull Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerX86BaseImpl.h

diff --git a/src/IceAssemblerX86BaseImpl.h b/src/IceAssemblerX86BaseImpl.h

index 2f9cda8c027553d1f871580d3a5d925635e867c6..5b853fdb2cc7cfa9c9fb358541df3ee080e9e0ac 100644

--- a/src/IceAssemblerX86BaseImpl.h

+++ b/src/IceAssemblerX86BaseImpl.h

@@ -304,7 +304,7 @@ void AssemblerX86Base<Machine>::movsx(Type SrcTy,

typename Traits::GPRRegister src) {

AssemblerBuffer::EnsureCapacity ensured(&Buffer);

bool ByteSized = isByteSizedType(SrcTy);

- emitRexRB(IceType_ForceRexW, dst, SrcTy, src);

+ emitRexRB(RexTypeForceRexW, dst, SrcTy, src);

if (ByteSized || SrcTy == IceType_i16) {

emitUint8(0x0F);

emitUint8(ByteSized ? 0xBE : 0xBF);

@@ -321,7 +321,7 @@ void AssemblerX86Base<Machine>::movsx(Type SrcTy,

const typename Traits::Address &src) {

AssemblerBuffer::EnsureCapacity ensured(&Buffer);

bool ByteSized = isByteSizedType(SrcTy);

- emitRex(SrcTy, src, IceType_ForceRexW, dst);

+ emitRex(SrcTy, src, RexTypeForceRexW, dst);

if (ByteSized || SrcTy == IceType_i16) {

emitUint8(0x0F);

emitUint8(ByteSized ? 0xBE : 0xBF);

« no previous file with comments | « src/IceAssemblerX86Base.h ('k') | src/IceInstX8664.h » ('j') | no next file with comments »