Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/common/chrome_version_info_android.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix OWNERS (copy from //chrome/OWNERS) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_version_info_android.cc
diff --git a/chrome/common/chrome_version_info_android.cc b/chrome/common/chrome_version_info_android.cc
index cfca3da14a8a82070853d6e5bd4845de5bf8f3ed..ce2961fe0cde5a734c4904a051a88a42d80bafd4 100644
--- a/chrome/common/chrome_version_info_android.cc
+++ b/chrome/common/chrome_version_info_android.cc
@@ -13,32 +13,32 @@ namespace chrome {
// static
std::string VersionInfo::GetVersionStringModifier() {
switch (GetChannel()) {
- case CHANNEL_UNKNOWN: return "unknown";
- case CHANNEL_CANARY: return "canary";
- case CHANNEL_DEV: return "dev";
- case CHANNEL_BETA: return "beta";
- case CHANNEL_STABLE: return std::string();
+ case version_info::CHANNEL_UNKNOWN: return "unknown";
+ case version_info::CHANNEL_CANARY: return "canary";
+ case version_info::CHANNEL_DEV: return "dev";
+ case version_info::CHANNEL_BETA: return "beta";
+ case version_info::CHANNEL_STABLE: return std::string();
}
NOTREACHED() << "Unknown channel " << GetChannel();
return std::string();
}
// static
-VersionInfo::Channel VersionInfo::GetChannel() {
+version_info::Channel VersionInfo::GetChannel() {
const base::android::BuildInfo* bi = base::android::BuildInfo::GetInstance();
DCHECK(bi && bi->package_name());
if (!strcmp(bi->package_name(), "com.android.chrome")
|| !strcmp(bi->package_name(), "com.chrome.work"))
- return CHANNEL_STABLE;
+ return version_info::CHANNEL_STABLE;
if (!strcmp(bi->package_name(), "com.chrome.beta"))
- return CHANNEL_BETA;
+ return version_info::CHANNEL_BETA;
if (!strcmp(bi->package_name(), "com.chrome.dev"))
- return CHANNEL_DEV;
+ return version_info::CHANNEL_DEV;
if (!strcmp(bi->package_name(), "com.chrome.canary"))
- return CHANNEL_CANARY;
+ return version_info::CHANNEL_CANARY;
- return CHANNEL_UNKNOWN;
+ return version_info::CHANNEL_UNKNOWN;
}
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698