Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: chrome/browser/about_flags.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix OWNERS (copy from //chrome/OWNERS) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 2d0c2ff791687ca1305b31386c1cb5738888883e..f04100067ff3ad9c0ca2133664258cd4ea79d5d1 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2183,27 +2183,27 @@ void GetSanitizedEnabledFlags(
}
bool SkipConditionalExperiment(const Experiment& experiment) {
- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
+ version_info::Channel channel = chrome::VersionInfo::GetChannel();
#if defined(OS_ANDROID)
// enable-data-reduction-proxy-dev is only available for the Dev/Beta channel.
if (!strcmp("enable-data-reduction-proxy-dev", experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_BETA &&
- channel != chrome::VersionInfo::CHANNEL_DEV) {
+ channel != version_info::CHANNEL_BETA &&
+ channel != version_info::CHANNEL_DEV) {
return true;
}
// enable-data-reduction-proxy-alt is only available for the Dev channel.
if (!strcmp("enable-data-reduction-proxy-alt", experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_DEV) {
+ channel != version_info::CHANNEL_DEV) {
return true;
}
// enable-data-reduction-proxy-carrier-test is only available for Chromium
// builds and the Canary/Dev channel.
if (!strcmp("enable-data-reduction-proxy-carrier-test",
experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_DEV &&
- channel != chrome::VersionInfo::CHANNEL_CANARY &&
- channel != chrome::VersionInfo::CHANNEL_UNKNOWN) {
+ channel != version_info::CHANNEL_DEV &&
+ channel != version_info::CHANNEL_CANARY &&
+ channel != version_info::CHANNEL_UNKNOWN) {
return true;
}
#endif
@@ -2211,10 +2211,10 @@ bool SkipConditionalExperiment(const Experiment& experiment) {
// data-reduction-proxy-lo-fi is only available for Chromium builds and
// the Canary/Dev/Beta channels.
if (!strcmp("data-reduction-proxy-lo-fi", experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_BETA &&
- channel != chrome::VersionInfo::CHANNEL_DEV &&
- channel != chrome::VersionInfo::CHANNEL_CANARY &&
- channel != chrome::VersionInfo::CHANNEL_UNKNOWN) {
+ channel != version_info::CHANNEL_BETA &&
+ channel != version_info::CHANNEL_DEV &&
+ channel != version_info::CHANNEL_CANARY &&
+ channel != version_info::CHANNEL_UNKNOWN) {
return true;
}
@@ -2222,9 +2222,9 @@ bool SkipConditionalExperiment(const Experiment& experiment) {
// builds and the Canary/Dev channels.
if (!strcmp("enable-data-reduction-proxy-config-client",
experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_DEV &&
- channel != chrome::VersionInfo::CHANNEL_CANARY &&
- channel != chrome::VersionInfo::CHANNEL_UNKNOWN) {
+ channel != version_info::CHANNEL_DEV &&
+ channel != version_info::CHANNEL_CANARY &&
+ channel != version_info::CHANNEL_UNKNOWN) {
return true;
}
@@ -2233,9 +2233,9 @@ bool SkipConditionalExperiment(const Experiment& experiment) {
// builds and Canary/Dev channel.
if (!strcmp("enable-data-reduction-proxy-bypass-warnings",
experiment.internal_name) &&
- channel != chrome::VersionInfo::CHANNEL_UNKNOWN &&
- channel != chrome::VersionInfo::CHANNEL_CANARY &&
- channel != chrome::VersionInfo::CHANNEL_DEV) {
+ channel != version_info::CHANNEL_UNKNOWN &&
+ channel != version_info::CHANNEL_CANARY &&
+ channel != version_info::CHANNEL_DEV) {
return true;
}
#endif

Powered by Google App Engine
This is Rietveld 408576698