chrome/app/close_handle_hook_win.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/close_handle_hook_win.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix OWNERS (copy from //chrome/OWNERS) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/close_handle_hook_win.cc

diff --git a/chrome/app/close_handle_hook_win.cc b/chrome/app/close_handle_hook_win.cc

index 939818751cba5015e43b8a8c8ea58793bc00b85a..34ea222e3061fe879c168edc85296790bc6f70c0 100644

--- a/chrome/app/close_handle_hook_win.cc

+++ b/chrome/app/close_handle_hook_win.cc

@@ -184,10 +184,10 @@ bool UseHooks() {

#if defined(ARCH_CPU_X86_64)

return false;

#elif defined(NDEBUG)

- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();

- if (channel == chrome::VersionInfo::CHANNEL_CANARY ||

- channel == chrome::VersionInfo::CHANNEL_DEV ||

- channel == chrome::VersionInfo::CHANNEL_UNKNOWN) {

+ version_info::Channel channel = chrome::VersionInfo::GetChannel();

+ if (channel == version_info::CHANNEL_CANARY ||

+ channel == version_info::CHANNEL_DEV ||

+ channel == version_info::CHANNEL_UNKNOWN) {

return true;

}