chrome/common/BUILD.gn - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix lost changes to //chrome/common/BUILD.gn and fix compilation of app_window_intercept_all_keys_u… Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index fc85ced6f94a3639c29a0985929e9ad6008a26cf..23fc42cee150c3ce2ef82ff50d8f856740796926 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -48,7 +48,6 @@ static_library("common") {

"//chrome/common/safe_browsing:proto",

]

deps = [

- ":version",

"//base:base",

"//base:i18n",

"//base:prefs",

@@ -69,6 +68,7 @@ static_library("common") {

"//components/policy:policy_component_common",

"//components/translate/core/common",

"//components/variations",

+ "//components/version_info",

"//content/public/common",

"//crypto",

"//extensions/common:common_constants",

@@ -260,12 +260,6 @@ source_set("result_codes") {

}

import("//chrome/version.gni")

-process_version("version") {

- visibility = [ ":common" ]

- template_file = "chrome_version_info_values.h.version"

- output = "$target_gen_dir/chrome_version_info_values.h"

process_version("make_chrome_version") {

template_file = "chrome_version.cc.version"

output = "$target_gen_dir/chrome_version.cc"