extensions/browser/api/app_window/app_window_apitest.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_window/app_window_apitest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_window/app_window_apitest.cc

diff --git a/extensions/browser/api/app_window/app_window_apitest.cc b/extensions/browser/api/app_window/app_window_apitest.cc

index 6aa666df536cf4719784de863b2312977ff3e5b9..5c84e072d1fa47eef431a3d53a80848fd00237a6 100644

--- a/extensions/browser/api/app_window/app_window_apitest.cc

+++ b/extensions/browser/api/app_window/app_window_apitest.cc

@@ -152,7 +152,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

}

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiAlphaEnabledInStable) {

- extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);

+ extensions::ScopedCurrentChannel channel(version_info::Channel::STABLE);

EXPECT_TRUE(RunPlatformAppTestWithFlags(

"platform_apps/windows_api_alpha_enabled/in_stable",

// Ignore manifest warnings because the extension will not load at all

@@ -170,7 +170,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

WindowsApiVisibleOnAllWorkspacesInStable) {

- extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);

+ extensions::ScopedCurrentChannel channel(version_info::Channel::STABLE);

EXPECT_TRUE(RunPlatformAppTest(

"platform_apps/windows_api_visible_on_all_workspaces/in_stable"))

<< message_;