chrome/common/gcm_desktop_util.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/gcm_desktop_util.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/gcm_desktop_util.cc

diff --git a/chrome/common/gcm_desktop_util.cc b/chrome/common/gcm_desktop_util.cc

index cfb8bfcf9b601960800b1fc6631e4b430a167046..8c7ea3a65d909897629db7ea8effa22473ec1c8a 100644

--- a/chrome/common/gcm_desktop_util.cc

+++ b/chrome/common/gcm_desktop_util.cc

@@ -42,17 +42,17 @@ GCMClient::ChromePlatform GetPlatform() {

}

GCMClient::ChromeChannel GetChannel() {

- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();

+ version_info::Channel channel = chrome::VersionInfo::GetChannel();

switch (channel) {

- case chrome::VersionInfo::CHANNEL_UNKNOWN:

+ case version_info::Channel::UNKNOWN:

return GCMClient::CHANNEL_UNKNOWN;

- case chrome::VersionInfo::CHANNEL_CANARY:

+ case version_info::Channel::CANARY:

return GCMClient::CHANNEL_CANARY;

- case chrome::VersionInfo::CHANNEL_DEV:

+ case version_info::Channel::DEV:

return GCMClient::CHANNEL_DEV;

- case chrome::VersionInfo::CHANNEL_BETA:

+ case version_info::Channel::BETA:

return GCMClient::CHANNEL_BETA;

- case chrome::VersionInfo::CHANNEL_STABLE:

+ case version_info::Channel::STABLE:

return GCMClient::CHANNEL_STABLE;

default:

NOTREACHED();