Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5030)

Unified Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
index 75a68574dd592b1db04b570cd5d6be948350329c..90cbdd26742d5c485c901324781d85051278af94 100644
--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler_unittest.cc
@@ -45,7 +45,7 @@ class UIOverrideTest : public testing::Test {
TEST_F(UIOverrideTest, ParseManifest) {
- extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_DEV);
+ extensions::ScopedCurrentChannel channel(version_info::Channel::DEV);
// This functionality requires a feature flag.
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
"--enable-override-bookmarks-ui", "1");
@@ -73,7 +73,7 @@ TEST_F(UIOverrideTest, ParseManifest) {
}
TEST_F(UIOverrideTest, ParseBrokenManifest) {
- extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_DEV);
+ extensions::ScopedCurrentChannel channel(version_info::Channel::DEV);
// This functionality requires a feature flag.
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
"--enable-override-bookmarks-ui", "1");

Powered by Google App Engine
This is Rietveld 408576698