chrome/browser/upgrade_detector_impl.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/upgrade_detector_impl.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/upgrade_detector_impl.cc

diff --git a/chrome/browser/upgrade_detector_impl.cc b/chrome/browser/upgrade_detector_impl.cc

index 2f03dbe4488623f046c493b0b00a2146b36258e9..98ddeda605759add69525aede5043ac7b911fa5f 100644

--- a/chrome/browser/upgrade_detector_impl.cc

+++ b/chrome/browser/upgrade_detector_impl.cc

@@ -97,9 +97,9 @@ bool IsUnstableChannel() {

// but no anymore. But other platform may still need the file thread.

// crbug.com/366647.

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();

- return channel == chrome::VersionInfo::CHANNEL_DEV ||

- channel == chrome::VersionInfo::CHANNEL_CANARY;

+ version_info::Channel channel = chrome::VersionInfo::GetChannel();

+ return channel == version_info::Channel::DEV ||

+ channel == version_info::Channel::CANARY;

}

#if !defined(OS_WIN)