chrome/browser/ui/hung_plugin_tab_helper.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/hung_plugin_tab_helper.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/hung_plugin_tab_helper.cc

diff --git a/chrome/browser/ui/hung_plugin_tab_helper.cc b/chrome/browser/ui/hung_plugin_tab_helper.cc

index afcd1e8d8590f6aef2e901b3bc85b3fa5d98ff82..12ef3be61cf7f17c858a6cea049d54c659488f53 100644

--- a/chrome/browser/ui/hung_plugin_tab_helper.cc

+++ b/chrome/browser/ui/hung_plugin_tab_helper.cc

@@ -355,8 +355,8 @@ void HungPluginTabHelper::KillPlugin(int child_id) {

// diagnose inter-process deadlocks.

// Only do that on the Canary channel, for 20% of pepper plugin hangs.

if (base::RandInt(0, 100) < 20) {

- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();

- if (channel == chrome::VersionInfo::CHANNEL_CANARY) {

+ version_info::Channel channel = chrome::VersionInfo::GetChannel();

+ if (channel == version_info::Channel::CANARY) {

scoped_ptr<OwnedHandleVector> renderer_handles(new OwnedHandleVector);

HANDLE current_process = ::GetCurrentProcess();

content::RenderProcessHost::iterator renderer_iter =