chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc

diff --git a/chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc b/chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc

index f87fd5fad448eddc23c0401b378753888a70f00a..b1e05f4c871069472e50ec4695a69c9517e4a935 100644

--- a/chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc

+++ b/chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc

@@ -13,9 +13,9 @@ namespace browser_sync {

void ChromeReportUnrecoverableError() {

// Only upload on canary/dev builds to avoid overwhelming crash server.

- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();

- if (channel != chrome::VersionInfo::CHANNEL_CANARY &&

- channel != chrome::VersionInfo::CHANNEL_DEV) {

+ version_info::Channel channel = chrome::VersionInfo::GetChannel();

+ if (channel != version_info::Channel::CANARY &&

+ channel != version_info::Channel::DEV) {

return;

}