chrome/browser/shell_integration_linux.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_linux.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/shell_integration_linux.cc

diff --git a/chrome/browser/shell_integration_linux.cc b/chrome/browser/shell_integration_linux.cc

index 4e1c305b76fed7b747c47923deb03cf26159f2dd..3c646b3ba2181466505f12b63a7b2182641eab81 100644

--- a/chrome/browser/shell_integration_linux.cc

+++ b/chrome/browser/shell_integration_linux.cc

@@ -586,12 +586,12 @@ std::string GetProgramClassName() {

std::string GetDesktopName(base::Environment* env) {

#if defined(GOOGLE_CHROME_BUILD)

- chrome::VersionInfo::Channel product_channel(

+ version_info::Channel product_channel(

chrome::VersionInfo::GetChannel());

switch (product_channel) {

- case chrome::VersionInfo::CHANNEL_DEV:

+ case version_info::Channel::DEV:

return "google-chrome-unstable.desktop";

- case chrome::VersionInfo::CHANNEL_BETA:

+ case version_info::Channel::BETA:

return "google-chrome-beta.desktop";

default:

return "google-chrome.desktop";

« no previous file with comments | « chrome/browser/shell_integration.cc ('k') | chrome/browser/shell_integration_mac.mm » ('j') | no next file with comments »