chrome/browser/password_manager/password_manager_browsertest.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_manager_browsertest.cc

diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc

index 915796b2e1747d6e5192d9b86879b86784877b07..cee06e8e68d9f15ddf227e50ffb08e0a0c25ea34 100644

--- a/chrome/browser/password_manager/password_manager_browsertest.cc

+++ b/chrome/browser/password_manager/password_manager_browsertest.cc

@@ -1125,7 +1125,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,

ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));

observer.Wait();

if (chrome::VersionInfo::GetChannel() ==

- chrome::VersionInfo::CHANNEL_UNKNOWN) {

+ version_info::Channel::UNKNOWN) {

// Passwords getting auto-saved, no prompt.

EXPECT_FALSE(prompt_observer->IsShowingPrompt());

EXPECT_FALSE(password_store->IsEmpty());