chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 3ab2d017bb7c226e2fa1a4f2648ea702f5431bd8..e77d03cd4422dfc0b4107fe338aefaaf609bff88 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -377,8 +377,8 @@ void ChromeMetricsServiceClient::Initialize() {

// Report exit funnels for canary and dev only.

bool report_exit_funnels = false;

switch (chrome::VersionInfo::GetChannel()) {

- case chrome::VersionInfo::CHANNEL_CANARY:

- case chrome::VersionInfo::CHANNEL_DEV:

+ case version_info::Channel::CANARY:

+ case version_info::Channel::DEV:

report_exit_funnels = true;

break;

}