Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5170)

Unified Diff: chrome/browser/extensions/service_worker_apitest.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/service_worker_apitest.cc
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 1c4a1b6becd18c0051bc29e77ca6f1537c01bbbe..a0662d2b21d05ead6576354b7ebc7da8b5175d16 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -11,7 +11,7 @@ class ServiceWorkerTest : public ExtensionApiTest {
public:
// Set the channel to "trunk" since service workers are restricted to trunk.
ServiceWorkerTest()
- : current_channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}
+ : current_channel_(version_info::Channel::UNKNOWN) {}
~ServiceWorkerTest() override {}
@@ -36,7 +36,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, RegisterServiceWorkersOnTrunk) {
// behavior - which is for it to fail.
IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, CannotRegisterServiceWorkersOnDev) {
ScopedCurrentChannel current_channel_override(
- chrome::VersionInfo::CHANNEL_DEV);
+ version_info::Channel::DEV);
ExtensionTestMessageListener listener(false);
ASSERT_FALSE(RunExtensionTest("service_worker/register")) << message_;
ASSERT_TRUE(listener.WaitUntilSatisfied());
« no previous file with comments | « chrome/browser/extensions/extension_browsertest.cc ('k') | chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698