chrome/app/chrome_crash_reporter_client.cc - Issue 1257633002: Componentize VersionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_crash_reporter_client.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/chrome_crash_reporter_client.cc

diff --git a/chrome/app/chrome_crash_reporter_client.cc b/chrome/app/chrome_crash_reporter_client.cc

index 067ab53ef926ce7d0cce29e5af3f1e367bc9f3e2..b0eba46d1f5af4e1751dfa0abf3be25e90fc98b2 100644

--- a/chrome/app/chrome_crash_reporter_client.cc

+++ b/chrome/app/chrome_crash_reporter_client.cc

@@ -33,7 +33,7 @@

#if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_IOS)

#include "chrome/browser/crash_upload_list.h"

-#include "chrome/common/chrome_version_info_values.h"

+#include "components/version_info/version_info_values.h"

#endif

#if defined(OS_POSIX)

@@ -322,7 +322,7 @@ bool ChromeCrashReporterClient::GetCollectStatsConsent() {

bool is_guest_session = base::CommandLine::ForCurrentProcess()->HasSwitch(

chromeos::switches::kGuestSession);

bool is_stable_channel =

- chrome::VersionInfo::GetChannel() == chrome::VersionInfo::CHANNEL_STABLE;

+ chrome::VersionInfo::GetChannel() == version_info::Channel::STABLE;

if (is_guest_session && is_stable_channel)

return false;

« no previous file with comments | « chrome/app/DEPS ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »