chrome/common/metrics/version_utils.h - Issue 1257633002: Componentize VersionInfo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/metrics/version_utils.h

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/gcm_desktop_util.cc ('k') | chrome/common/metrics/version_utils.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_COMMON_METRICS_VERSION_UTILS_H_	5 #ifndef CHROME_COMMON_METRICS_VERSION_UTILS_H_

6 #define CHROME_COMMON_METRICS_VERSION_UTILS_H_	6 #define CHROME_COMMON_METRICS_VERSION_UTILS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "chrome/common/chrome_version_info.h"	10 #include "chrome/common/chrome_version_info.h"

11 #include "components/metrics/proto/system_profile.pb.h"	11 #include "components/metrics/proto/system_profile.pb.h"

12	12

13 namespace metrics {	13 namespace metrics {

14	14

15 // Build a string including the Chrome app version, suffixed by "-64" on 64-bit	15 // Build a string including the Chrome app version, suffixed by "-64" on 64-bit

16 // platforms, and "-devel" on developer builds.	16 // platforms, and "-devel" on developer builds.

17 std::string GetVersionString();	17 std::string GetVersionString();

18	18

19 // Translates chrome::VersionInfo::Channel to the equivalent	19 // Translates version_info::Channel to the equivalent

20 // SystemProfileProto::Channel.	20 // SystemProfileProto::Channel.

21 SystemProfileProto::Channel AsProtobufChannel(	21 SystemProfileProto::Channel AsProtobufChannel(

22 chrome::VersionInfo::Channel channel);	22 version_info::Channel channel);

23	23

24 } // namespace metrics	24 } // namespace metrics

25	25

26 #endif // CHROME_COMMON_METRICS_VERSION_UTILS_H_	26 #endif // CHROME_COMMON_METRICS_VERSION_UTILS_H_

OLD	NEW