chrome/browser/ui/apps/chrome_app_window_client.cc - Issue 1257633002: Componentize VersionInfo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/apps/chrome_app_window_client.cc

Issue 1257633002: Componentize VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert version_info::Channel to a "class enum" Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_mac.mm ('k') | chrome/browser/ui/cocoa/first_run_dialog.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/apps/chrome_app_window_client.h"	5 #include "chrome/browser/ui/apps/chrome_app_window_client.h"

6	6

7 #include "base/memory/singleton.h"	7 #include "base/memory/singleton.h"

8 #include "chrome/browser/apps/scoped_keep_alive.h"	8 #include "chrome/browser/apps/scoped_keep_alive.h"

9 #include "chrome/browser/devtools/devtools_window.h"	9 #include "chrome/browser/devtools/devtools_window.h"

10 #include "chrome/common/extensions/features/feature_channel.h"	10 #include "chrome/common/extensions/features/feature_channel.h"

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62	62

63 DevToolsWindow* devtools_window =	63 DevToolsWindow* devtools_window =

64 DevToolsWindow::FindDevToolsWindow(agent.get());	64 DevToolsWindow::FindDevToolsWindow(agent.get());

65 if (devtools_window)	65 if (devtools_window)

66 devtools_window->SetLoadCompletedCallback(callback);	66 devtools_window->SetLoadCompletedCallback(callback);

67 else	67 else

68 callback.Run();	68 callback.Run();

69 }	69 }

70	70

71 bool ChromeAppWindowClient::IsCurrentChannelOlderThanDev() {	71 bool ChromeAppWindowClient::IsCurrentChannelOlderThanDev() {

72 return extensions::GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV;	72 return extensions::GetCurrentChannel() > version_info::Channel::DEV;

73 }	73 }

OLD	NEW