Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1257623004: Send appropriate pseudo-headers in HTTP/2 CONNECT request. (Closed)

Created:
5 years, 4 months ago by Bence
Modified:
5 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send appropriate pseudo-headers in HTTP/2 CONNECT request. Change CreateSpdyHeadersFromHttpRequest() to use the appropriate pseudo-headers in an HTTP/2 CONNECT request: ":authority" with mandatory port, no ":path", no ":scheme". BUG=433784 Committed: https://crrev.com/6b996d532f7781fbc44cdecfba600a26d98d8d9a Cr-Commit-Position: refs/heads/master@{#340872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -35 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_utils.cc View 1 chunk +35 lines, -25 lines 0 comments Download
M net/spdy/spdy_http_utils_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 4 months ago (2015-07-28 17:17:35 UTC) #2
Ryan Hamilton
lgtm
5 years, 4 months ago (2015-07-28 21:09:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623004/1
5 years, 4 months ago (2015-07-29 10:47:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-29 10:51:41 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 10:52:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b996d532f7781fbc44cdecfba600a26d98d8d9a
Cr-Commit-Position: refs/heads/master@{#340872}

Powered by Google App Engine
This is Rietveld 408576698