chrome/browser/signin/account_reconcilor_unittest.cc - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/account_reconcilor_unittest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc ('k') | chrome/browser/signin/cross_device_promo_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/account_reconcilor_unittest.cc

diff --git a/chrome/browser/signin/account_reconcilor_unittest.cc b/chrome/browser/signin/account_reconcilor_unittest.cc

index 7cfc4d655a0f35e1d0268e35a9ecc566baba3f32..04cedaf7228a451c194a2b3554b8ab59d10f7284 100644

--- a/chrome/browser/signin/account_reconcilor_unittest.cc

+++ b/chrome/browser/signin/account_reconcilor_unittest.cc

@@ -15,7 +15,7 @@

#include "chrome/browser/signin/chrome_signin_client_factory.h"

#include "chrome/browser/signin/fake_gaia_cookie_manager_service.h"

#include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"

-#include "chrome/browser/signin/fake_signin_manager.h"

+#include "chrome/browser/signin/fake_signin_manager_builder.h"

#include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"

#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"

#include "chrome/browser/signin/signin_manager_factory.h"

@@ -174,7 +174,7 @@ void AccountReconcilorTest::SetUp() {

GaiaCookieManagerServiceFactory::GetInstance(),

FakeGaiaCookieManagerService::Build));

factories.push_back(std::make_pair(SigninManagerFactory::GetInstance(),

- FakeSigninManagerBase::Build));

+ BuildFakeSigninManagerBase));

factories.push_back(std::make_pair(AccountReconcilorFactory::GetInstance(),

MockAccountReconcilor::Build));