chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc ('k') | chrome/browser/signin/account_reconcilor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

index 65c496e7454a7950ad437fb660e1cdab8fcabee5..603e8f2652d865aaec95cd501f0f66d1cf25583a 100644

--- a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

+++ b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

@@ -15,10 +15,11 @@

#include "chrome/browser/prefs/browser_prefs.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/signin/account_fetcher_service_factory.h"

+#include "chrome/browser/signin/account_tracker_service_factory.h"

#include "chrome/browser/signin/chrome_signin_client_factory.h"

#include "chrome/browser/signin/fake_account_fetcher_service.h"

#include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"

-#include "chrome/browser/signin/fake_signin_manager.h"

+#include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"

#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"

#include "chrome/browser/signin/signin_manager_factory.h"

#include "chrome/browser/signin/test_signin_client_builder.h"

@@ -34,6 +35,7 @@

#include "components/policy/core/common/schema_registry.h"

#include "components/signin/core/browser/account_tracker_service.h"

#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"

+#include "components/signin/core/browser/fake_signin_manager.h"

#include "components/signin/core/browser/signin_manager.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/notification_details.h"

@@ -86,7 +88,11 @@ const char kHostedDomainResponse[] =

class SigninManagerFake : public FakeSigninManager {

public:

explicit SigninManagerFake(Profile* profile)

- : FakeSigninManager(profile) {

+ : FakeSigninManager(

+ ChromeSigninClientFactory::GetForProfile(profile),

+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile),

+ AccountTrackerServiceFactory::GetForProfile(profile),

+ GaiaCookieManagerServiceFactory::GetForProfile(profile)) {

Initialize(NULL);

}