chrome/browser/app_controller_mac_unittest.mm - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/app_controller_mac_unittest.mm

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import <Cocoa/Cocoa.h>	5 #import <Cocoa/Cocoa.h>

6	6

7 #include "base/files/file_path.h"	7 #include "base/files/file_path.h"

8 #include "base/mac/scoped_nsobject.h"	8 #include "base/mac/scoped_nsobject.h"

9 #include "base/run_loop.h"	9 #include "base/run_loop.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

11 #include "chrome/app/chrome_command_ids.h"	11 #include "chrome/app/chrome_command_ids.h"

12 #import "chrome/browser/app_controller_mac.h"	12 #import "chrome/browser/app_controller_mac.h"

13 #include "chrome/browser/browser_process.h"	13 #include "chrome/browser/browser_process.h"

14 #include "chrome/browser/profiles/profile_manager.h"	14 #include "chrome/browser/profiles/profile_manager.h"

15 #include "chrome/browser/signin/fake_signin_manager.h"

16 #include "chrome/browser/signin/signin_error_controller_factory.h"	15 #include "chrome/browser/signin/signin_error_controller_factory.h"

17 #include "chrome/browser/signin/signin_manager_factory.h"	16 #include "chrome/browser/signin/signin_manager_factory.h"

18 #include "chrome/browser/sync/profile_sync_service.h"	17 #include "chrome/browser/sync/profile_sync_service.h"

19 #include "chrome/browser/sync/profile_sync_service_factory.h"	18 #include "chrome/browser/sync/profile_sync_service_factory.h"

20 #include "chrome/browser/sync/profile_sync_service_mock.h"	19 #include "chrome/browser/sync/profile_sync_service_mock.h"

21 #include "chrome/common/chrome_constants.h"	20 #include "chrome/common/chrome_constants.h"

22 #include "chrome/common/pref_names.h"	21 #include "chrome/common/pref_names.h"

23 #include "chrome/grit/chromium_strings.h"	22 #include "chrome/grit/chromium_strings.h"

24 #include "chrome/grit/generated_resources.h"	23 #include "chrome/grit/generated_resources.h"

25 #include "chrome/test/base/testing_browser_process.h"	24 #include "chrome/test/base/testing_browser_process.h"

(...skipping 191 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
217	216

218 [followingNonSeparator setHidden:YES];	217 [followingNonSeparator setHidden:YES];

219 [AppController updateSigninItem:signinMenuItem	218 [AppController updateSigninItem:signinMenuItem

220 shouldShow:YES	219 shouldShow:YES

221 currentProfile:profile_];	220 currentProfile:profile_];

222	221

223 EXPECT_TRUE([followingNonSeparator isEnabled]);	222 EXPECT_TRUE([followingNonSeparator isEnabled]);

224 EXPECT_FALSE([signinMenuItem isHidden]);	223 EXPECT_FALSE([signinMenuItem isHidden]);

225 EXPECT_TRUE([followingNonSeparator isHidden]);	224 EXPECT_TRUE([followingNonSeparator isHidden]);

226 }	225 }

OLD	NEW