Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/yasm/BUILD.gn

Issue 1257613004: Really suppress -Wswitch warnings in third_party/yasm for GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/BUILD.gn
diff --git a/third_party/yasm/BUILD.gn b/third_party/yasm/BUILD.gn
index 23e160e14b19f70eaee268c67b557b58bf1befac..dc6c1166142a00266349d6a4650a2dfba63448dd 100644
--- a/third_party/yasm/BUILD.gn
+++ b/third_party/yasm/BUILD.gn
@@ -148,16 +148,19 @@ if (current_toolchain == host_toolchain) {
"source/patched-yasm/tools/re2c/translate.c",
]
+ config("re2c_warnings") {
+ # re2c is missing CLOSEVOP from one switch.
+ if (is_posix || is_clang) {
+ cflags = [ "-Wno-switch" ]
+ }
+ }
+
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
":yasm_config",
"//build/config/compiler:no_chromium_code",
+ ":re2c_warnings",
]
-
- # re2c is missing CLOSEVOP from one switch.
- if (is_posix) {
- cflags = [ "-Wno-switch" ]
- }
deps = [
"//build/config/sanitizers:deps",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698