Source/bindings/scripts/v8_attributes.py - Issue 1257613003: bindings: Supports inheritance of [Unforgeable] attributes as accessor-type properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1257613003: bindings: Supports inheritance of [Unforgeable] attributes as accessor-type properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Made inherit_unforgeable_attributes more robust. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/interface_dependency_resolver.py ('K') | « Source/bindings/scripts/utilities.py ('k') | Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 2913c8430685178a85ce60be9bb5b7f23b2f5243..0be9c69669a7531966cf715f984c10841d1d8e09 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -124,7 +124,7 @@ def attribute_context(interface, attribute):

'is_check_security_for_window': is_check_security_for_window,

'is_custom_element_callbacks': is_custom_element_callbacks,

# TODO(yukishiino): Make all DOM attributes accessor-type properties.

- 'is_data_type_property': constructor_type or interface.name == 'Window' or interface.name == 'Location' or (interface.name == 'Event' and attribute.name == 'isTrusted'),

+ 'is_data_type_property': constructor_type or interface.name == 'Window' or interface.name == 'Location',

'is_getter_raises_exception': # [RaisesException]

'RaisesException' in extended_attributes and

extended_attributes['RaisesException'] in (None, 'Getter'),