ui/base/ime/input_method_mac.mm - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_mac.mm

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Sadrul's comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method_mac.mm

diff --git a/ui/base/ime/input_method_mac.mm b/ui/base/ime/input_method_mac.mm

index 0e9cac557e9f734226f8d7f52f4439810c4fa167..ff6118fa165dea974b03288be3ff0a48d5600a91 100644

--- a/ui/base/ime/input_method_mac.mm

+++ b/ui/base/ime/input_method_mac.mm

@@ -18,9 +18,9 @@ bool InputMethodMac::OnUntranslatedIMEMessage(const base::NativeEvent& event,

return false;

}

-bool InputMethodMac::DispatchKeyEvent(const ui::KeyEvent& event) {

+void InputMethodMac::DispatchKeyEvent(ui::KeyEvent* event) {

// This is used on Mac only to dispatch events post-IME.

- return DispatchKeyEventPostIME(event);

+ ignore_result(DispatchKeyEventPostIME(event));

}

void InputMethodMac::OnCaretBoundsChanged(const TextInputClient* client) {

« no previous file with comments | « ui/base/ime/input_method_mac.h ('k') | ui/base/ime/input_method_minimal.h » ('j') | no next file with comments »