ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc - Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

Issue 1257603006: Refactoring for the InputMethod & InputMethodDelegate interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test failures on windows. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/base/ime/input_method_win.cc ('K') | « ui/views/controls/textfield/textfield_unittest.cc ('k') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('j') | ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

index 17888bc6231a09272613d6b8f396624cc045a599..5bee7fd959f9bf26e5d884a5be348927ec4b5872 100644

--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

@@ -805,8 +805,7 @@ bool DesktopWindowTreeHostWin::HandleMouseEvent(const ui::MouseEvent& event) {

}

void DesktopWindowTreeHostWin::HandleKeyEvent(ui::KeyEvent* event) {

- GetInputMethod()->DispatchKeyEvent(*event);

- event->StopPropagation();

+ GetInputMethod()->DispatchKeyEvent(event);

}

void DesktopWindowTreeHostWin::HandleTouchEvent(