Refactoring for the InputMethod & InputMethodDelegate interfaces.

ui/base/ime/input_method_chromeos.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_
 #define UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_
 
 #include <set>
 #include <string>
 
@@ skipping 14 matching lines @@
       public chromeos::IMEInputContextHandlerInterface {
  public:
   explicit InputMethodChromeOS(internal::InputMethodDelegate* delegate);
   ~InputMethodChromeOS() override;
 
   // Overridden from InputMethod:
   void OnFocus() override;
   void OnBlur() override;
   bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
                                 NativeEventResult* result) override;
-  bool DispatchKeyEvent(const ui::KeyEvent& event) override;
+  void DispatchKeyEvent(ui::KeyEvent* event) override;
   void OnTextInputTypeChanged(const TextInputClient* client) override;
   void OnCaretBoundsChanged(const TextInputClient* client) override;
   void CancelComposition(const TextInputClient* client) override;
   void OnInputLocaleChanged() override;
   std::string GetInputLocale() override;
   bool IsCandidatePopupOpen() const override;
 
  protected:
   // Converts |text| into CompositionText.
   void ExtractCompositionText(const chromeos::CompositionText& text,
                               uint32 cursor_position,
                               CompositionText* out_composition) const;
 
   // Process a key returned from the input method.
-  virtual void ProcessKeyEventPostIME(const ui::KeyEvent& event,
+  virtual void ProcessKeyEventPostIME(ui::KeyEvent* event,
                                       bool handled);
 
   // Resets context and abandon all pending results and key events.
   void ResetContext();
 
  private:
   class PendingKeyEvent;
 
   // Overridden from InputMethodBase:
   void OnWillChangeFocusedClient(TextInputClient* focused_before,
                                  TextInputClient* focused) override;
   void OnDidChangeFocusedClient(TextInputClient* focused_before,
                                 TextInputClient* focused) override;
 
   // Asks the client to confirm current composition text.
   void ConfirmCompositionText();
 
   // Checks the availability of focused text input client and update focus
   // state.
   void UpdateContextFocusState();
 
   // Processes a key event that was already filtered by the input method.
   // A VKEY_PROCESSKEY may be dispatched to the EventTargets.
   // It returns the result of whether the event has been stopped propagation
   // when dispatching post IME.
-  bool ProcessFilteredKeyPressEvent(const ui::KeyEvent& event);
+  void ProcessFilteredKeyPressEvent(ui::KeyEvent* event);
 
   // Processes a key event that was not filtered by the input method.
-  void ProcessUnfilteredKeyPressEvent(const ui::KeyEvent& event);
+  void ProcessUnfilteredKeyPressEvent(ui::KeyEvent* event);
 
   // Sends input method result caused by the given key event to the focused text
   // input client.
-  void ProcessInputMethodResult(const ui::KeyEvent& event, bool filtered);
+  void ProcessInputMethodResult(ui::KeyEvent* event, bool filtered);
 
   // Checks if the pending input method result needs inserting into the focused
   // text input client as a single character.
   bool NeedInsertChar() const;
 
   // Checks if there is pending input method result.
   bool HasInputMethodResult() const;
 
   // Sends a fake key event for IME composing without physical key events.
-  void SendFakeProcessKeyEvent(bool pressed) const;
+  // Returns true if the faked key event is stopped propagation.
+  bool SendFakeProcessKeyEvent(bool pressed) const;
 
   // Passes keyevent and executes character composition if necessary. Returns
   // true if character composer comsumes key event.
   bool ExecuteCharacterComposer(const ui::KeyEvent& event);
 
   // chromeos::IMEInputContextHandlerInterface overrides:
   void CommitText(const std::string& text) override;
   void UpdateCompositionText(const chromeos::CompositionText& text,
                              uint32 cursor_pos,
                              bool visible) override;
   void DeleteSurroundingText(int32 offset, uint32 length) override;
 
   // Hides the composition text.
   void HidePreeditText();
 
   // Callback function for IMEEngineHandlerInterface::ProcessKeyEvent.
-  void ProcessKeyEventDone(const ui::KeyEvent* event, bool is_handled);
+  void ProcessKeyEventDone(ui::KeyEvent* event, bool is_handled);
 
   // Returns whether an non-password input field is focused.
   bool IsNonPasswordInputFieldFocused();
 
   // Returns true if an text input field is focused.
   bool IsInputFieldFocused();
 
   // Pending composition text generated by the current pending key event.
   // It'll be sent to the focused text input client as soon as we receive the
   // processing result of the pending key event.
@@ skipping 23 matching lines @@
 
   // Used for making callbacks.
   base::WeakPtrFactory<InputMethodChromeOS> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InputMethodChromeOS);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_