Issue 1257603005: Minimize retrieving SkGlyph in GrTextContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257603005: Minimize retrieving SkGlyph in GrTextContext (Closed)

Created:
5 years, 5 months ago by joshua.litt

Modified:
5 years, 5 months ago

Reviewers:
jvanverth1, joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Minimize retrieving SkGlyph in GrTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/6c2c2b07ed83e1f83008fac6eb1b62670b1dbdb1

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -109 lines)			Patch
M	src/gpu/GrAtlasTextContext.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	1	15 chunks	+37 lines, -48 lines	0 comments	Download
M	src/gpu/GrBatchFontCache.h	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/gpu/GrBatchFontCache.cpp	View	1	3 chunks	+9 lines, -12 lines	0 comments	Download
M	src/gpu/GrFontScaler.h	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/gpu/GrFontScaler.cpp	View	1	5 chunks	+13 lines, -33 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257603005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257603005/20001

5 years, 5 months ago (2015-07-24 17:26:12 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-24 17:37:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6c2c2b07ed83e1f83008fac6eb1b62670b1dbdb1

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages