Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1257603004: [mips] Fix Load/StoreGlobalContext stubs. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, Paul Lind
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mips] Fix Load/StoreGlobalContext stubs. Fix invalid tail calls and wrong context register. R=ishell@chromium.org Committed: https://crrev.com/dd1a26de5c8ab9d4b539a33a2ec6a8dac877b243 Cr-Commit-Position: refs/heads/master@{#29844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/mips/code-stubs-mips.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-24 12:11:38 UTC) #1
Benedikt Meurer
Hey Igor, Here's the combined fix that you suggested. Please take a look. Thanks, Benedikt
5 years, 5 months ago (2015-07-24 12:12:18 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-24 12:27:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257603004/1
5 years, 5 months ago (2015-07-24 12:28:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 12:37:13 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd1a26de5c8ab9d4b539a33a2ec6a8dac877b243 Cr-Commit-Position: refs/heads/master@{#29844}
5 years, 5 months ago (2015-07-24 12:37:26 UTC) #7
paul.l...
5 years, 5 months ago (2015-07-26 04:37:47 UTC) #8
Message was sent while issue was closed.
Sorry for all the problems, I'd missed that this was behind the flag, so my
testing was useless. Igor, Benedikt, thanks a lot for fixing these! One more fix
coming.

Powered by Google App Engine
This is Rietveld 408576698