third_party/snappy/BUILD.gn - Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/snappy/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/snappy/BUILD.gn

diff --git a/third_party/snappy/BUILD.gn b/third_party/snappy/BUILD.gn

index e8de575e40ea0a6f40c55be53fb58d2fcc71a79b..4af0e81d57d850236dd6a358376b5e4fa04df88d 100644

--- a/third_party/snappy/BUILD.gn

+++ b/third_party/snappy/BUILD.gn

@@ -31,10 +31,6 @@

configs += [ "//build/config/compiler:no_chromium_code" ]

public_configs = [ ":snappy_config" ]

- if (is_win) {

- cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.

- }

if (is_clang) {

# snappy-stubs-internal.h unapologetically has: using namespace std

# https://code.google.com/p/snappy/issues/detail?id=70

« no previous file with comments | « third_party/re2/BUILD.gn ('k') | no next file » | no next file with comments »