Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: third_party/snappy/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/re2/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("snappy_config") { 5 config("snappy_config") {
6 include_dirs = [ "src" ] 6 include_dirs = [ "src" ]
7 7
8 # These OS-specific generated headers were made by running the configure 8 # These OS-specific generated headers were made by running the configure
9 # script offline. 9 # script offline.
10 if (is_win) { 10 if (is_win) {
(...skipping 13 matching lines...) Expand all
24 "src/snappy-stubs-internal.cc", 24 "src/snappy-stubs-internal.cc",
25 "src/snappy-stubs-internal.h", 25 "src/snappy-stubs-internal.h",
26 "src/snappy.cc", 26 "src/snappy.cc",
27 "src/snappy.h", 27 "src/snappy.h",
28 ] 28 ]
29 29
30 configs -= [ "//build/config/compiler:chromium_code" ] 30 configs -= [ "//build/config/compiler:chromium_code" ]
31 configs += [ "//build/config/compiler:no_chromium_code" ] 31 configs += [ "//build/config/compiler:no_chromium_code" ]
32 public_configs = [ ":snappy_config" ] 32 public_configs = [ ":snappy_config" ]
33 33
34 if (is_win) {
35 cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison.
36 }
37
38 if (is_clang) { 34 if (is_clang) {
39 # snappy-stubs-internal.h unapologetically has: using namespace std 35 # snappy-stubs-internal.h unapologetically has: using namespace std
40 # https://code.google.com/p/snappy/issues/detail?id=70 36 # https://code.google.com/p/snappy/issues/detail?id=70
41 configs -= [ "//build/config/clang:extra_warnings" ] 37 configs -= [ "//build/config/clang:extra_warnings" ]
42 } 38 }
43 } 39 }
OLDNEW
« no previous file with comments | « third_party/re2/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698