Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/protobuf/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_win) { 5 if (is_win) {
6 config_h_dir = "vsprojects" 6 config_h_dir = "vsprojects"
7 } else { 7 } else {
8 config_h_dir = "." 8 config_h_dir = "."
9 } 9 }
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 "src/google/protobuf/unknown_field_set.h", 70 "src/google/protobuf/unknown_field_set.h",
71 "src/google/protobuf/wire_format_lite.cc", 71 "src/google/protobuf/wire_format_lite.cc",
72 "src/google/protobuf/wire_format_lite.h", 72 "src/google/protobuf/wire_format_lite.h",
73 "src/google/protobuf/wire_format_lite_inl.h", 73 "src/google/protobuf/wire_format_lite_inl.h",
74 "$config_h_dir/config.h", 74 "$config_h_dir/config.h",
75 ] 75 ]
76 76
77 protobuf_lite_cflags = [] 77 protobuf_lite_cflags = []
78 if (is_win) { 78 if (is_win) {
79 protobuf_lite_cflags = [ 79 protobuf_lite_cflags = [
80 "/wd4018", # Signed/unsigned mismatch in comparison. 80 "/wd4018", # signed/unsigned mismatch in comparison
81 "/wd4244", # Implicit conversion, possible loss of data. 81 "/wd4244", # implicit conversion, possible loss of data
82 "/wd4355", # 'this' used in base member initializer list. 82 "/wd4355", # 'this' used in base member initializer list
83 "/wd4267", # Size_t to int truncation. 83 "/wd4267", # size_t to int truncation
84 "/wd4291", # No matching operator delete for a placement new. 84 "/wd4291", # no matching operator delete for a placement new
85 ] 85 ]
86 } 86 }
87 87
88 component("protobuf_lite") { 88 component("protobuf_lite") {
89 sources = protobuf_lite_sources 89 sources = protobuf_lite_sources
90 90
91 configs -= [ "//build/config/compiler:chromium_code" ] 91 configs -= [ "//build/config/compiler:chromium_code" ]
92 configs += [ "//build/config/compiler:no_chromium_code" ] 92 configs += [ "//build/config/compiler:no_chromium_code" ]
93 if (is_win) { 93 if (is_win) {
94 configs -= [ "//build/config/win:lean_and_mean" ] 94 configs -= [ "//build/config/win:lean_and_mean" ]
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 ":copy_google", 329 ":copy_google",
330 ":copy_google_protobuf", 330 ":copy_google_protobuf",
331 ":copy_google_protobuf_internal", 331 ":copy_google_protobuf_internal",
332 ] 332 ]
333 333
334 # Targets that depend on this should depend on the copied data files. 334 # Targets that depend on this should depend on the copied data files.
335 data = get_target_outputs(":copy_google") 335 data = get_target_outputs(":copy_google")
336 data += get_target_outputs(":copy_google_protobuf") 336 data += get_target_outputs(":copy_google_protobuf")
337 data += get_target_outputs(":copy_google_protobuf_internal") 337 data += get_target_outputs(":copy_google_protobuf_internal")
338 } 338 }
OLDNEW
« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | third_party/qcms/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698