Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Side by Side Diff: third_party/mesa/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/protobuf/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 6
7 config("mesa_headers_config") { 7 config("mesa_headers_config") {
8 include_dirs = [ "src/include" ] 8 include_dirs = [ "src/include" ]
9 if (use_x11) { 9 if (use_x11) {
10 defines = [ "MESA_EGL_NO_X11_HEADERS" ] 10 defines = [ "MESA_EGL_NO_X11_HEADERS" ]
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 # mesa_internal_config is prepended to the config lists. Flags that 118 # mesa_internal_config is prepended to the config lists. Flags that
119 # disable warnings need to be appended instead so that they show up 119 # disable warnings need to be appended instead so that they show up
120 # after flags like -Wall. (gn orders flags on a target before flags from 120 # after flags like -Wall. (gn orders flags on a target before flags from
121 # configs.) 121 # configs.)
122 config("mesa_internal_warnings") { 122 config("mesa_internal_warnings") {
123 cflags = [] 123 cflags = []
124 if (is_clang) { 124 if (is_clang) {
125 cflags += [ 125 cflags += [
126 "-Wno-tautological-constant-out-of-range-compare", 126 "-Wno-tautological-constant-out-of-range-compare",
127 "-Wno-mismatched-tags", # Fixed upstream. 127 "-Wno-mismatched-tags", # Fixed upstream.
128
129 # mesa's STATIC_ASSERT() macro expands to an ununused typedef. 128 # mesa's STATIC_ASSERT() macro expands to an ununused typedef.
130 "-Wno-unused-local-typedef", 129 "-Wno-unused-local-typedef",
131 ] 130 ]
132 } 131 }
133 if (is_win) { 132 if (is_win) {
134 # TODO(scottmg): http://crbug.com/143877 These should be removed if 133 # TODO(scottmg): http://crbug.com/143877 These should be removed if
135 # Mesa is ever rolled and the warnings are fixed. 134 # Mesa is ever rolled and the warnings are fixed.
136 cflags += [ 135 cflags += [
137 "/wd4005", # Macro defined twice. 136 "/wd4005", # Macro defined twice.
138 "/wd4018", # Signed/unsigned mismatch in comparison.
139 "/wd4065", # Switch statement contains 'default' but no 'case' labels. 137 "/wd4065", # Switch statement contains 'default' but no 'case' labels.
140 "/wd4090", # 'Operation' : different 'modifier' qualifiers 138 "/wd4090", # 'Operation' : different 'modifier' qualifiers
141 "/wd4099", # Type name struct-vs-class doesn't match. 139 "/wd4099", # Type name struct-vs-class doesn't match.
142 "/wd4273", # Inconsistent DLL linkage. 140 "/wd4273", # Inconsistent DLL linkage.
143 "/wd4291", # No matching operator delete found for placement new. 141 "/wd4291", # No matching operator delete found for placement new.
144 "/wd4305", # Truncation from int to float. 142 "/wd4305", # Truncation from int to float.
145 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits. 143 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
146 "/wd4345", # POD-type default initializers. 144 "/wd4345", # POD-type default initializers.
147 ] 145 ]
148 } 146 }
(...skipping 569 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 "KEYWORD2=GLAPIENTRY", 716 "KEYWORD2=GLAPIENTRY",
719 ] 717 ]
720 } 718 }
721 } 719 }
722 } else { 720 } else {
723 # Placeholder to allow targets to unconditionally depend on this. 721 # Placeholder to allow targets to unconditionally depend on this.
724 group("osmesa") { 722 group("osmesa") {
725 } 723 }
726 } # !is_android 724 } # !is_android
727 # TODO(GYP) Android osmesa_in_lib_dir target. 725 # TODO(GYP) Android osmesa_in_lib_dir target.
OLDNEW
« no previous file with comments | « third_party/libxml/BUILD.gn ('k') | third_party/protobuf/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698