Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1257583007: Revert of Enable C4018 globally for the GN build, and disable per-target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/filesystem/file_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 default_warning_flags_cc = [] 716 default_warning_flags_cc = []
717 if (is_win) { 717 if (is_win) {
718 # TODO(thakis): Make this unconditional once llvm.org/PR24167 is fixed. 718 # TODO(thakis): Make this unconditional once llvm.org/PR24167 is fixed.
719 if (!is_clang || !is_asan) { 719 if (!is_clang || !is_asan) {
720 default_warning_flags += [ "/WX" ] # Treat warnings as errors. 720 default_warning_flags += [ "/WX" ] # Treat warnings as errors.
721 } 721 }
722 722
723 default_warning_flags += [ 723 default_warning_flags += [
724 # Warnings permanently disabled: 724 # Warnings permanently disabled:
725 725
726 # TODO(GYP) The GYP build doesn't have this globally enabled but disabled
727 # for a bunch of individual targets. Re-enable this globally when those
728 # targets are fixed.
729 "/wd4018", # Comparing signed and unsigned values.
730
726 # C4127: conditional expression is constant 731 # C4127: conditional expression is constant
727 # This warning can in theory catch dead code and other problems, but 732 # This warning can in theory catch dead code and other problems, but
728 # triggers in far too many desirable cases where the conditional 733 # triggers in far too many desirable cases where the conditional
729 # expression is either set by macros or corresponds some legitimate 734 # expression is either set by macros or corresponds some legitimate
730 # compile-time constant expression (due to constant template args, 735 # compile-time constant expression (due to constant template args,
731 # conditionals comparing the sizes of different types, etc.). Some of 736 # conditionals comparing the sizes of different types, etc.). Some of
732 # these can be worked around, but it's not worth it. 737 # these can be worked around, but it's not worth it.
733 "/wd4127", 738 "/wd4127",
734 739
735 # C4251: 'identifier' : class 'type' needs to have dll-interface to be 740 # C4251: 'identifier' : class 'type' needs to have dll-interface to be
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
1258 cflags += [ "-gsplit-dwarf" ] 1263 cflags += [ "-gsplit-dwarf" ]
1259 } 1264 }
1260 } 1265 }
1261 } 1266 }
1262 1267
1263 config("no_symbols") { 1268 config("no_symbols") {
1264 if (!is_win) { 1269 if (!is_win) {
1265 cflags = [ "-g0" ] 1270 cflags = [ "-g0" ]
1266 } 1271 }
1267 } 1272 }
OLDNEW
« no previous file with comments | « no previous file | components/filesystem/file_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698