Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1257583005: [test] Shorten excessive webkit test. (Closed)

Created:
5 years, 4 months ago by Michael Achenbach
Modified:
5 years, 4 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Shorten excessive webkit test. BUG= Committed: https://crrev.com/d4d5663a2f432a97721a15044f118154a287a1ed Cr-Commit-Position: refs/heads/master@{#29895}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/webkit/fast/js/excessive-comma-usage.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/webkit/fast/js/excessive-comma-usage-expected.txt View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257583005/1
5 years, 4 months ago (2015-07-27 21:00:27 UTC) #2
Michael Achenbach
PTAL https://codereview.chromium.org/1257583005/diff/1/test/webkit/fast/js/excessive-comma-usage-expected.txt File test/webkit/fast/js/excessive-comma-usage-expected.txt (left): https://codereview.chromium.org/1257583005/diff/1/test/webkit/fast/js/excessive-comma-usage-expected.txt#oldcode31 test/webkit/fast/js/excessive-comma-usage-expected.txt:31: FAIL new Function(commaExpressionTestString)() should be true. Threw exception ...
5 years, 4 months ago (2015-07-27 21:21:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 21:30:54 UTC) #6
vogelheim
lgtm I suspect the test has some value, as a parser/compiler stress test. Keeping but ...
5 years, 4 months ago (2015-07-28 09:47:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257583005/1
5 years, 4 months ago (2015-07-28 10:16:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 10:17:26 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 10:17:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d5663a2f432a97721a15044f118154a287a1ed
Cr-Commit-Position: refs/heads/master@{#29895}

Powered by Google App Engine
This is Rietveld 408576698