[Proof-of-concept] PlzNavigate and Service Worker

content/common/frame_messages.h

Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 2d884239b3d7e5b43b834081a8f9f48badf79c8e..163148b5ba4682ed173bbf877a17705649033f6b 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -630,11 +630,12 @@ IPC_MESSAGE_ROUTED1(FrameMsg_SelectPopupMenuItem,
 // Tells the renderer that a navigation is ready to commit.  The renderer should
 // request |stream_url| to get access to the stream containing the body of the
 // response.
-IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation,
-                    content::ResourceResponseHead,   /* response */
-                    GURL,                            /* stream_url */
-                    content::CommonNavigationParams, /* common_params */
-                    content::RequestNavigationParams /* request_params */)
+IPC_MESSAGE_ROUTED5(FrameMsg_CommitNavigation,
+                    content::ResourceResponseHead,    /* response */
+                    GURL,                             /* stream_url */
+                    content::CommonNavigationParams,  /* common_params */
+                    content::RequestNavigationParams, /* request_params */
+                    int /* navigation_provider_id */)

[michaeln, 2015/07/30 01:35:08]

There are many existing params values related to navigations, i'm not so
familiar with the varuios NavigationParams structs (CommonNavParams,
StartNavigationParams, or RequestNavigationParams). Would it make sense to
incorporate this new value into one of those existing param structures instead
of tacking on the additional parameter here and elsewhere?

[horo, 2015/07/30 11:05:41]

Humm.. I am also not familiar with the NavigationParams structs.

[Fabrice (no longer in Chrome), 2015/08/06 15:39:15]

CommonNavigationParams are for parameters needed by all navigations.
BeginNavigationParams are for extra parameters needed by renderer-inititated
navigations.

In our case, I think the argument should be in CommonNavigationParams and the
parameters passed around in this CL should be refactored as such.

[nasko, 2015/08/07 17:51:12]

Do we need to carry the provider ID from the browser to the renderer? If not,
then it probably doesn't belong in Common*, but rather in
RequestNavigationParams.

 
 // PlzNavigate
 // Tells the renderer that a navigation failed with the error code |error_code|