[Proof-of-concept] PlzNavigate and Service Worker

content/child/resource_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/child/resource_dispatcher.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 738 matching lines @@
   request->skip_service_worker = request_info.skip_service_worker;
   request->should_reset_appcache = request_info.should_reset_appcache;
   request->fetch_request_mode = request_info.fetch_request_mode;
   request->fetch_credentials_mode = request_info.fetch_credentials_mode;
   request->fetch_request_context_type = request_info.fetch_request_context_type;
   request->fetch_frame_type = request_info.fetch_frame_type;
   request->enable_load_timing = request_info.enable_load_timing;
   request->enable_upload_progress = request_info.enable_upload_progress;
   request->do_not_prompt_for_login = request_info.do_not_prompt_for_login;
 
-  if ((request_info.referrer.policy == blink::WebReferrerPolicyDefault ||
-       request_info.referrer.policy ==
-           blink::WebReferrerPolicyNoReferrerWhenDowngrade) &&
-      request_info.referrer.url.SchemeIsCryptographic() &&
-      !request_info.url.SchemeIsCryptographic()) {
-    LOG(FATAL) << "Trying to send secure referrer for insecure request "
-               << "without an appropriate referrer policy.\n"
-               << "URL = " << request_info.url << "\n"
-               << "Referrer = " << request_info.referrer.url;
-  }
 
   const RequestExtraData kEmptyData;
   const RequestExtraData* extra_data;
   if (request_info.extra_data)
     extra_data = static_cast<RequestExtraData*>(request_info.extra_data);
   else
     extra_data = &kEmptyData;
+
+  if (extra_data->navigation_provider_id() == kInvalidServiceWorkerProviderId) {
+    if ((request_info.referrer.policy == blink::WebReferrerPolicyDefault ||

[michaeln, 2015/07/30 01:35:08]

Would it make sense to explicitly use a different more lax referrer policy for
for plznavigate requests?

[nasko, 2015/08/07 17:51:11]

What is the rationale for that? There should be nothing different whether the
request is made by existing codepaths or by PlzNavigate.

+         request_info.referrer.policy ==
+             blink::WebReferrerPolicyNoReferrerWhenDowngrade) &&
+        request_info.referrer.url.SchemeIsCryptographic() &&
+        !request_info.url.SchemeIsCryptographic()) {
+      LOG(FATAL) << "Trying to send secure referrer for insecure request "
+                 << "without an appropriate referrer policy.\n"
+                 << "URL = " << request_info.url << "\n"
+                 << "Referrer = " << request_info.referrer.url;
+    }
+  }
+
   request->visiblity_state = extra_data->visibility_state();
   request->render_frame_id = extra_data->render_frame_id();
   request->is_main_frame = extra_data->is_main_frame();
   request->parent_is_main_frame = extra_data->parent_is_main_frame();
   request->parent_render_frame_id = extra_data->parent_render_frame_id();
   request->allow_download = extra_data->allow_download();
   request->transition_type = extra_data->transition_type();
   request->should_replace_current_entry =
       extra_data->should_replace_current_entry();
   request->transferred_request_child_id =
       extra_data->transferred_request_child_id();
   request->transferred_request_request_id =
       extra_data->transferred_request_request_id();
   request->service_worker_provider_id =
       extra_data->service_worker_provider_id();
   request->request_body = request_body;
   if (frame_origin)
     *frame_origin = extra_data->frame_origin();
+
+  // PlzNavigate: Hack to avoid the referrer check failure in browser process.

[nasko, 2015/08/07 17:51:11]

What is this failure?

+  if (extra_data->navigation_provider_id() != kInvalidServiceWorkerProviderId)
+    request->referrer = GURL();
   return request.Pass();
 }
 
 }  // namespace content