Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: test/unittests/compiler/interpreter-assembler-unittest.cc

Issue 1257543003: [Interpreter] Add more bytecode definitions and add operand types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Attempt to address patch set 3 comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/interpreter-assembler-unittest.cc
diff --git a/test/unittests/compiler/interpreter-assembler-unittest.cc b/test/unittests/compiler/interpreter-assembler-unittest.cc
index dcde9a9cb5cefe36f14978d5f52d013487801ac1..b5b69049fac68c783d771c879df669ed802fb9d1 100644
--- a/test/unittests/compiler/interpreter-assembler-unittest.cc
+++ b/test/unittests/compiler/interpreter-assembler-unittest.cc
@@ -14,7 +14,7 @@ namespace internal {
namespace compiler {
const interpreter::Bytecode kBytecodes[] = {
-#define DEFINE_BYTECODE(Name, _) interpreter::Bytecode::k##Name,
+#define DEFINE_BYTECODE(Name, ...) interpreter::Bytecode::k##Name,
BYTECODE_LIST(DEFINE_BYTECODE)
#undef DEFINE_BYTECODE
};
@@ -93,12 +93,12 @@ TARGET_TEST_F(InterpreterAssemblerTest, Dispatch) {
}
-TARGET_TEST_F(InterpreterAssemblerTest, BytecodeArg) {
+TARGET_TEST_F(InterpreterAssemblerTest, BytecodeOperand) {
TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
InterpreterAssemblerForTest m(this, bytecode);
- int number_of_args = interpreter::Bytecodes::NumberOfArguments(bytecode);
+ int number_of_args = interpreter::Bytecodes::NumberOfOperands(bytecode);
for (int i = 0; i < number_of_args; i++) {
- Node* load_arg_node = m.BytecodeArg(i);
+ Node* load_arg_node = m.BytecodeOperand(i);
EXPECT_THAT(load_arg_node,
m.IsLoad(kMachUint8,
IsParameter(Linkage::kInterpreterBytecodeParameter),
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698