src/compiler/interpreter-assembler.h - Issue 1257543003: [Interpreter] Add more bytecode definitions and add operand types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/interpreter-assembler.h

Issue 1257543003: [Interpreter] Add more bytecode definitions and add operand types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Attempt to address patch set 3 comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/interpreter-assembler.h

diff --git a/src/compiler/interpreter-assembler.h b/src/compiler/interpreter-assembler.h

index edbe86d07bfa290ce3bb7dada672587ffa1d1390..573d87f78727ae7c2a1f8bd326a61200a4c1e7da 100644

--- a/src/compiler/interpreter-assembler.h

+++ b/src/compiler/interpreter-assembler.h

@@ -42,7 +42,7 @@ class InterpreterAssembler {

Node* NumberConstant(double value);

// Returns the bytecode argument |index| for the current bytecode.

rmcilroy 2015/07/28 08:58:12 update comment too please.

oth 2015/07/28 13:24:14 Done. sed'ited it and missed this, doh!

- Node* BytecodeArg(int index);

+ Node* BytecodeOperand(int index);

// Loads from and stores to the interpreter register file.

Node* LoadRegister(int index);

« no previous file with comments | « no previous file | src/compiler/interpreter-assembler.cc » ('j') | src/interpreter/bytecodes.h » ('J')