src/compiler/interpreter-assembler.cc - Issue 1257543003: [Interpreter] Add more bytecode definitions and add operand types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/interpreter-assembler.cc

Issue 1257543003: [Interpreter] Add more bytecode definitions and add operand types. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Preprocessor robust method of describing bytecode operands. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/interpreter-assembler.cc

diff --git a/src/compiler/interpreter-assembler.cc b/src/compiler/interpreter-assembler.cc

index 691fa61db576a0b7030373df7e51da2b405b6ce9..ab35fe29857b6385d501a0f8b9020dcb06809199 100644

--- a/src/compiler/interpreter-assembler.cc

+++ b/src/compiler/interpreter-assembler.cc

@@ -90,7 +90,7 @@ Node* InterpreterAssembler::RegisterFrameOffset(Node* index) {

Node* InterpreterAssembler::BytecodeArg(int delta) {

rmcilroy 2015/07/27 14:56:57 Could you change this to BytecodeOperand as well p

oth 2015/07/27 16:59:00 Done.

- DCHECK_LT(delta, interpreter::Bytecodes::NumberOfArguments(bytecode_));

+ DCHECK_LT(delta, interpreter::Bytecodes::NumberOfOperands(bytecode_));

return raw_assembler_->Load(kMachUint8, BytecodePointer(),

Int32Constant(1 + delta));

}

« no previous file with comments | « no previous file | src/interpreter/bytecodes.h » ('j') | src/interpreter/bytecodes.h » ('J')