[Interpreter] Add more bytecode definitions and add operand types.

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <iomanip>
 #include <sstream>
 
 #include "src/v8.h"
 
 #include "src/accessors.h"
@@ skipping 11602 matching lines @@
     it.rinfo()->Print(GetIsolate(), os);
   }
   os << "\n";
 }
 #endif  // ENABLE_DISASSEMBLER
 
 
 void BytecodeArray::Disassemble(std::ostream& os) {
   os << "Frame size " << frame_size() << "\n";
   Vector<char> buf = Vector<char>::New(50);
-  int bytecode_size = 0;
-  for (int i = 0; i < this->length(); i += bytecode_size) {
-    interpreter::Bytecode bytecode = static_cast<interpreter::Bytecode>(get(i));
-    bytecode_size = interpreter::Bytecodes::Size(bytecode);
+  int bytes = 0;
+  for (int i = 0; i < this->length(); i += bytes) {
+    interpreter::Bytecode bytecode = interpreter::Bytecodes::FromByte(get(i));
+    bytes = interpreter::Bytecodes::Size(bytecode);
 
     SNPrintF(buf, "%p : ", GetFirstBytecodeAddress() + i);
     os << buf.start();
-    for (int j = 0; j < bytecode_size; j++) {
+    for (int j = 0; j < bytes; j++) {
       SNPrintF(buf, "%02x ", get(i + j));
       os << buf.start();
     }
-    for (int j = bytecode_size; j < interpreter::Bytecodes::kMaximumSize; j++) {
+    for (int j = bytes; j < interpreter::Bytecodes::MaximumSize(); j++) {
       os << "   ";
     }
     os << bytecode << "\n";

[rmcilroy, 2015/07/28 08:58:12]

could we add the formatted versions of the arguments after the bytecode - e.g.,
r1 for register 1 and #123 for literal SMI 123, etc? (fine to do in another CL).

[oth, 2015/07/28 13:24:14]

Part of next patch.

   }
 }
 
 
 // static
 void JSArray::Initialize(Handle<JSArray> array, int capacity, int length) {
   DCHECK(capacity >= 0);
   array->GetIsolate()->factory()->NewJSArrayStorage(
       array, length, capacity, INITIALIZE_ARRAY_ELEMENTS_WITH_HOLE);
 }
@@ skipping 4275 matching lines @@
                                             Handle<Object> new_value) {
   if (cell->value() != *new_value) {
     cell->set_value(*new_value);
     Isolate* isolate = cell->GetIsolate();
     cell->dependent_code()->DeoptimizeDependentCodeGroup(
         isolate, DependentCode::kPropertyCellChangedGroup);
   }
 }
 }  // namespace internal
 }  // namespace v8